Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3754)

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.cc

Issue 1762373002: Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused (nit) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/content_setting_image_view.cc
diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
index e88ab5c3f5717dfaad2fb524f3ac242e1e3be424..a3b7640cee9233d14d98151610c663c4d0eb3110 100644
--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
@@ -259,9 +259,12 @@ void ContentSettingImageView::OnClick() {
views::Widget* bubble_widget =
parent_->delegate()->CreateViewsBubble(bubble_view_);
bubble_widget->AddObserver(this);
- // This is triggered by an input event, the icon will be in an active state
- // so the bubble doesn't need an arrow.
- if (ui::MaterialDesignController::IsModeMaterial())
+ // This is triggered by an input event. If the user clicks the icon while
+ // it's not animating, the icon will be placed in an active state, so the
+ // bubble doesn't need an arrow. If the user clicks during an animation,
+ // the animation simply pauses and no other visible state change occurs, so
+ // show the arrow in this case.
+ if (ui::MaterialDesignController::IsModeMaterial() && !pause_animation_)
bubble_view_->SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
bubble_widget->Show();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698