Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.h

Issue 1762373002: Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds ContentSettingBubbleContents::Show (show arrow on pause) Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/content_setting_bubble_contents.h
diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.h b/chrome/browser/ui/views/content_setting_bubble_contents.h
index 86b2e1047a1a6e92e6925139c1e112a7bea262d6..1b787ba3ef3373da2286762ec1e8f7a449470023 100644
--- a/chrome/browser/ui/views/content_setting_bubble_contents.h
+++ b/chrome/browser/ui/views/content_setting_bubble_contents.h
@@ -34,6 +34,7 @@ class LabelButton;
class MenuButton;
class MenuRunner;
class RadioButton;
+class Widget;
}
// ContentSettingBubbleContents is used when the user turns on different kinds
@@ -64,6 +65,10 @@ class ContentSettingBubbleContents : public content::WebContentsObserver,
void UpdateMenuLabel(content::MediaStreamType type,
const std::string& label);
+ // Creates and shows the bubble. Returns a bubble widget. With Material Design
+ // the bubble doesn't have an arrow unless |show_arrow| is set.
+ views::Widget* Show(bool show_arrow);
+
protected:
// views::BubbleDelegateView:
void Init() override;

Powered by Google App Engine
This is Rietveld 408576698