Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused

chrome/browser/ui/views/location_bar/content_setting_image_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/content_setting_image_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/themes/theme_properties.h"
 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"
@@ skipping 242 matching lines @@
   if (web_contents && !bubble_view_) {
     bubble_view_ = new ContentSettingBubbleContents(
                 content_setting_image_model_->CreateBubbleModel(
                     parent_->delegate()->GetContentSettingBubbleModelDelegate(),
                     web_contents, parent_->profile()),
                 web_contents, this, views::BubbleBorder::TOP_RIGHT);
     views::Widget* bubble_widget =
         parent_->delegate()->CreateViewsBubble(bubble_view_);
     bubble_widget->AddObserver(this);
     // This is triggered by an input event, the icon will be in an active state
-    // so the bubble doesn't need an arrow.
-    if (ui::MaterialDesignController::IsModeMaterial())
+    // so the bubble doesn't need an arrow. When animation is paused the anchor
+    // view doesn't show ink drop so the arrow is still shown.

[Peter Kasting, 2016/03/08 03:16:28]

Nit: Grammar.  How about:

This is triggered by an input event.  If the user clicks the icon while it's not
animating, the icon will be placed in an active state, so the bubble doesn't
need an arrow.  If the user clicks during an animation, the animation simply
pauses and no other visible state change occurs, so show the arrow in this case.

(Though, frankly, I'd almost rather just always show the arrows than have this
kind of complicated logic, but whatever.)

+    if (ui::MaterialDesignController::IsModeMaterial() && !pause_animation_)
       bubble_view_->SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
     bubble_widget->Show();
   }
 }
 
 void ContentSettingImageView::UpdateImage() {
   SetImage(content_setting_image_model_->GetIcon(GetTextColor()).AsImageSkia());
   image()->SetTooltipText(content_setting_image_model_->get_tooltip());
 }
 
 bool ContentSettingImageView::IsBubbleShowing() const {
   return bubble_view_ != nullptr;
 }