Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Side by Side Diff: chrome/browser/ui/views/content_setting_bubble_contents.cc

Issue 1762373002: Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds ContentSettingBubbleContents::Show (show arrow on pause) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/content_setting_bubble_contents.h" 5 #include "chrome/browser/ui/views/content_setting_bubble_contents.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/stl_util.h" 14 #include "base/stl_util.h"
15 #include "base/strings/utf_string_conversions.h" 15 #include "base/strings/utf_string_conversions.h"
16 #include "chrome/browser/plugins/plugin_finder.h" 16 #include "chrome/browser/plugins/plugin_finder.h"
17 #include "chrome/browser/plugins/plugin_metadata.h" 17 #include "chrome/browser/plugins/plugin_metadata.h"
18 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h" 18 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
19 #include "chrome/browser/ui/content_settings/content_setting_media_menu_model.h" 19 #include "chrome/browser/ui/content_settings/content_setting_media_menu_model.h"
20 #include "chrome/browser/ui/views/browser_dialogs.h" 20 #include "chrome/browser/ui/views/browser_dialogs.h"
21 #include "chrome/grit/generated_resources.h" 21 #include "chrome/grit/generated_resources.h"
22 #include "components/content_settings/core/browser/host_content_settings_map.h" 22 #include "components/content_settings/core/browser/host_content_settings_map.h"
23 #include "content/public/browser/plugin_service.h" 23 #include "content/public/browser/plugin_service.h"
24 #include "content/public/browser/web_contents.h" 24 #include "content/public/browser/web_contents.h"
25 #include "grit/components_strings.h" 25 #include "grit/components_strings.h"
26 #include "ui/base/cursor/cursor.h" 26 #include "ui/base/cursor/cursor.h"
27 #include "ui/base/l10n/l10n_util.h" 27 #include "ui/base/l10n/l10n_util.h"
28 #include "ui/base/material_design/material_design_controller.h"
28 #include "ui/base/models/simple_menu_model.h" 29 #include "ui/base/models/simple_menu_model.h"
29 #include "ui/base/resource/resource_bundle.h" 30 #include "ui/base/resource/resource_bundle.h"
30 #include "ui/gfx/font_list.h" 31 #include "ui/gfx/font_list.h"
31 #include "ui/gfx/text_utils.h" 32 #include "ui/gfx/text_utils.h"
32 #include "ui/views/controls/button/label_button.h" 33 #include "ui/views/controls/button/label_button.h"
33 #include "ui/views/controls/button/menu_button.h" 34 #include "ui/views/controls/button/menu_button.h"
34 #include "ui/views/controls/button/radio_button.h" 35 #include "ui/views/controls/button/radio_button.h"
35 #include "ui/views/controls/image_view.h" 36 #include "ui/views/controls/image_view.h"
36 #include "ui/views/controls/label.h" 37 #include "ui/views/controls/label.h"
37 #include "ui/views/controls/link.h" 38 #include "ui/views/controls/link.h"
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 it != media_menus_.end(); ++it) { 171 it != media_menus_.end(); ++it) {
171 if (it->second->type == type) { 172 if (it->second->type == type) {
172 it->first->SetText(base::UTF8ToUTF16(label)); 173 it->first->SetText(base::UTF8ToUTF16(label));
173 it->first->Layout(); 174 it->first->Layout();
174 return; 175 return;
175 } 176 }
176 } 177 }
177 NOTREACHED(); 178 NOTREACHED();
178 } 179 }
179 180
181 views::Widget* ContentSettingBubbleContents::Show(bool show_arrow) {
182 views::Widget* widget = views::BubbleDelegateView::CreateBubble(this);
183 // In the USER_GESTURE case, the icon will be in an active state so the
184 // bubble doesn't need an arrow.
185 if (ui::MaterialDesignController::IsModeMaterial() && !show_arrow)
186 SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
187 widget->Show();
188 return widget;
189 }
190
180 void ContentSettingBubbleContents::Init() { 191 void ContentSettingBubbleContents::Init() {
181 using views::GridLayout; 192 using views::GridLayout;
182 193
183 GridLayout* layout = new views::GridLayout(this); 194 GridLayout* layout = new views::GridLayout(this);
184 SetLayoutManager(layout); 195 SetLayoutManager(layout);
185 196
186 const int kSingleColumnSetId = 0; 197 const int kSingleColumnSetId = 0;
187 views::ColumnSet* column_set = layout->AddColumnSet(kSingleColumnSetId); 198 views::ColumnSet* column_set = layout->AddColumnSet(kSingleColumnSetId);
188 column_set->AddColumn(GridLayout::LEADING, GridLayout::FILL, 1, 199 column_set->AddColumn(GridLayout::LEADING, GridLayout::FILL, 1,
189 GridLayout::USE_PREF, 0, 0); 200 GridLayout::USE_PREF, 0, 0);
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 // Make sure the width is at least kMinMediaMenuButtonWidth. The 503 // Make sure the width is at least kMinMediaMenuButtonWidth. The
493 // maximum width will be clamped by kMaxContentsWidth of the view. 504 // maximum width will be clamped by kMaxContentsWidth of the view.
494 menu_width = std::max(kMinMediaMenuButtonWidth, menu_width + margins); 505 menu_width = std::max(kMinMediaMenuButtonWidth, menu_width + margins);
495 506
496 for (MediaMenuPartsMap::const_iterator i = media_menus_.begin(); 507 for (MediaMenuPartsMap::const_iterator i = media_menus_.begin();
497 i != media_menus_.end(); ++i) { 508 i != media_menus_.end(); ++i) {
498 i->first->SetMinSize(gfx::Size(menu_width, 0)); 509 i->first->SetMinSize(gfx::Size(menu_width, 0));
499 i->first->SetMaxSize(gfx::Size(menu_width, 0)); 510 i->first->SetMaxSize(gfx::Size(menu_width, 0));
500 } 511 }
501 } 512 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698