Remove build directory before performing perf tryjob.

Remove build directory before performing perf tryjob.

Since we were raising StepFailure exception, the perf try job was not able to build and test revision without patch.
By no raising exception perf tryjob will continue to work on revision without patch. Thus we'll know whether we have any issue with the patch.

BUG=591428

[prasadv, 2016-03-05 00:40:53]

prasadv@chromium.org changed reviewers:
+ dtu@chromium.org, robertocn@chromium.org

[RobertoCN, 2016-03-07 22:24:40]

LGTM with nit.

https://codereview.chromium.org/1762363003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/perf_try/api.py (left):

https://codereview.chromium.org/1762363003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/perf_try/api.py:203: if not overall_success:  #
pragma: no cover
Not raising an exception and instead returning the overall_success as a ret_code
make sense to me. However, I don't see how it's related to the removal of the
build directory.

We could at least add a note in the CL description saying why we are doing this.

[dtu, 2016-03-07 23:57:56]

lgtm

[prasadv, 2016-03-08 00:05:39]

On 2016/03/07 22:24:40, RobertoCN wrote:
> LGTM with nit.
> 
>
https://codereview.chromium.org/1762363003/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/perf_try/api.py (left):
> 
>
https://codereview.chromium.org/1762363003/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/perf_try/api.py:203: if not overall_success:  #
> pragma: no cover
> Not raising an exception and instead returning the overall_success as a
ret_code
> make sense to me. However, I don't see how it's related to the removal of the
> build directory.
> 
> We could at least add a note in the CL description saying why we are doing
this.

Since we were raising StepFailure exception, the perf try job was not able to
build and test revision without patch.
By no raising exception perf tryjob will continue to work on revision without
patch. Thus we'll know whether we have any issue with the patch.

[prasadv, 2016-03-08 00:06:40]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2016-03-08 00:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762363003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762363003/1

[commit-bot: I haz the power, 2016-03-08 00:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 00:13:36]

Try jobs failed on following builders:
  build_presubmit on chromium.buildbucket.swarming (JOB_FAILED,
https://annotation-parser.appspot.com/swarming/build/2d6c5e0efab5f910)

[dtu, 2016-03-08 18:34:13]

On 2016/03/08 at 00:05:39, prasadv wrote:
> On 2016/03/07 22:24:40, RobertoCN wrote:
> > LGTM with nit.
> > 
> >
https://codereview.chromium.org/1762363003/diff/1/scripts/slave/recipe_module...
> > File scripts/slave/recipe_modules/perf_try/api.py (left):
> > 
> >
https://codereview.chromium.org/1762363003/diff/1/scripts/slave/recipe_module...
> > scripts/slave/recipe_modules/perf_try/api.py:203: if not overall_success:  #
> > pragma: no cover
> > Not raising an exception and instead returning the overall_success as a
ret_code
> > make sense to me. However, I don't see how it's related to the removal of
the
> > build directory.
> > 
> > We could at least add a note in the CL description saying why we are doing
this.
> 
> Since we were raising StepFailure exception, the perf try job was not able to
build and test revision without patch.
> By no raising exception perf tryjob will continue to work on revision without
patch. Thus we'll know whether we have any issue with the patch.

Please put the explanation in the CL description.

[prasadv, 2016-03-09 00:16:19]

Description was changed from

==========
Remove build directory before performing perf tryjob.

BUG=591428
==========

to

==========
Remove build directory before performing perf tryjob.

Since we were raising StepFailure exception, the perf try job was not able to
build and test revision without patch.
By no raising exception perf tryjob will continue to work on revision without
patch. Thus we'll know whether we have any issue with the patch.

BUG=591428
==========

[prasadv, 2016-03-09 00:27:19]

The CQ bit was checked by prasadv@chromium.org

[prasadv, 2016-03-09 00:27:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertocn@chromium.org, dtu@chromium.org
Link to the patchset: https://codereview.chromium.org/1762363003/#ps20001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-03-09 00:27:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762363003/20001

[commit-bot: I haz the power, 2016-03-09 00:34:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 00:34:13]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)