Various cleanup

lib/src/compiler.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Command line tool to run the checker on a Dart program.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert' show JSON;
 import 'dart:math' as math;
@@ skipping 259 matching lines @@
   }
 
   void _compileHtml(Source source, CompilationNotifier notifier) {
     // TODO(jmesserly): reuse DartScriptsTask instead of copy/paste.
     var contents = context.getContents(source);
     var document = html.parse(contents.data, generateSpans: true);
     var scripts = document.querySelectorAll('script[type="application/dart"]');
 
     var loadedLibs = new LinkedHashSet<Uri>();
 
-    var htmlOutDir = path.dirname(getOutputPath(source.uri));
+    // If we're generating code, convert the HTML file as well.

[ochafik, 2016/03/04 23:27:57]

+1 !

+    // Otherwise, just search for Dart sources to analyze.
+    var htmlOutDir =
+        _jsGen != null ? path.dirname(getOutputPath(source.uri)) : null;
     for (var script in scripts) {
       Source scriptSource = null;
       var srcAttr = script.attributes['src'];
       if (srcAttr == null) {
         if (script.hasContent()) {
           var fragments = <ScriptFragment>[];
           for (var node in script.nodes) {
             if (node is html.Text) {
               var start = node.sourceSpan.start;
               fragments.add(new ScriptFragment(
                   start.offset, start.line, start.column, node.data));
             }
           }
           scriptSource = new DartScript(source, fragments);
         }
       } else if (AnalysisEngine.isDartFileName(srcAttr)) {
         scriptSource = context.sourceFactory.resolveUri(source, srcAttr);
       }
 
       if (scriptSource != null) {
         var lib = context.computeLibraryElement(scriptSource);
         _compileLibrary(lib, notifier);
-        script.replaceWith(_linkLibraries(lib, loadedLibs, from: htmlOutDir));
+        if (htmlOutDir != null) {
+          script.replaceWith(_linkLibraries(lib, loadedLibs, from: htmlOutDir));
+        }
       }
     }
 
-    fileSystem.writeAsStringSync(
-        getOutputPath(source.uri), document.outerHtml + '\n');
+    if (htmlOutDir != null) {
+      fileSystem.writeAsStringSync(
+          getOutputPath(source.uri), document.outerHtml + '\n');
+    }
   }
 
   html.DocumentFragment _linkLibraries(
       LibraryElement mainLib, LinkedHashSet<Uri> loaded,
       {String from}) {
     assert(from != null);
     var alreadyLoaded = loaded.length;
     _collectLibraries(mainLib, loaded);
 
     var newLibs = loaded.skip(alreadyLoaded);
@@ skipping 214 matching lines @@
   var files = [
     'harmony_feature_check.js',
     'dart_library.js',
     'dart/_runtime.js',
   ];
   files.addAll(corelibOrder.map(coreToFile));
   return files;
 }();
 
 final _log = new Logger('dev_compiler.src.compiler');