Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1762283003: Various cleanup (Closed)

Created:
4 years, 9 months ago by vsm
Modified:
4 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Various cleanup - Allow just analysis given html file - Checked mode fix for html-report - Clear pubspec.lock for transformer test - Format run R=jmesserly@google.com, ochafik@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0c5dd2d1e999c421d978a478e267aac6279e087a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -28 lines) Patch
M lib/src/closure/closure_type.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/js_metalet.dart View 3 chunks +14 lines, -7 lines 0 comments Download
M lib/src/codegen/side_effect_analysis.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/compiler.dart View 2 chunks +11 lines, -4 lines 1 comment Download
M lib/src/report/html_reporter.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/transformer/asset_source.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tool/patch_sdk.dart View 5 chunks +16 lines, -8 lines 0 comments Download
M tool/transformer_test.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
4 years, 9 months ago (2016-03-04 21:58:21 UTC) #3
ochafik
Thanks Vijay, lgtm! https://codereview.chromium.org/1762283003/diff/1/lib/src/compiler.dart File lib/src/compiler.dart (right): https://codereview.chromium.org/1762283003/diff/1/lib/src/compiler.dart#newcode280 lib/src/compiler.dart:280: // If we're generating code, convert ...
4 years, 9 months ago (2016-03-04 23:27:57 UTC) #4
Jennifer Messerly
lgtm
4 years, 9 months ago (2016-03-06 20:55:47 UTC) #5
vsm
4 years, 9 months ago (2016-03-09 20:58:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c5dd2d1e999c421d978a478e267aac6279e087a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698