Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1762273004: Check pointers convertible not values in sk_sp. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
hal.canary, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Check pointers convertible not values in sk_sp. The intent is to participate in overload resolution when the pointers are convertible, which is a bit different from when the values are convertible. This change makes sk_sp more consistent with unique_ptr.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M include/core/SkRefCnt.h View 5 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762273004/1
4 years, 9 months ago (2016-03-05 13:22:32 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-05 13:32:07 UTC) #6
bungeman-skia
4 years, 9 months ago (2016-03-05 16:24:07 UTC) #8
bungeman-skia
4 years, 9 months ago (2016-03-05 16:30:09 UTC) #9
Message was sent while issue was closed.
closed in favor of https://codereview.chromium.org/1771583002/ which has a test

Powered by Google App Engine
This is Rietveld 408576698