Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1762263002: MIPS: Fix [stubs] Introduce a dedicated FastNewObjectStub (Closed)

Created:
4 years, 9 months ago by ivica.bogosavljevic
Modified:
4 years, 9 months ago
Reviewers:
balazs.kilvady, miran.karic, Marija Antic, ilija.pavlovic, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix [stubs] Introduce a dedicated FastNewObjectStub Typo in implementation of FastNewObjectStub::Generate for MIPS32 cause unnecessary calls to slow Runtime::kNewObject TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations BUG= Committed: https://crrev.com/96efefd748aba2924a80aa1125cc973c03a53714 Cr-Commit-Position: refs/heads/master@{#34490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 9 months ago (2016-03-04 09:57:24 UTC) #3
akos.palfi.imgtec
LGTM, Thanks!
4 years, 9 months ago (2016-03-04 10:02:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762263002/1
4 years, 9 months ago (2016-03-04 10:11:23 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 10:46:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762263002/1
4 years, 9 months ago (2016-03-04 10:51:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 10:53:55 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 10:54:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96efefd748aba2924a80aa1125cc973c03a53714
Cr-Commit-Position: refs/heads/master@{#34490}

Powered by Google App Engine
This is Rietveld 408576698