[wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript.

[wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript.

R=binji@chromium.org,seththompson@chromium.org
BUG=

Committed: https://crrev.com/d130c6bdc6a424b068614592a0b79a34750af0fc
Cr-Commit-Position: refs/heads/master@{#34513}

[binji, 2016-03-04 05:13:26]

lgtm w/ comments

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/test-wasm...
File test/mjsunit/wasm/test-wasm-module-builder.js (right):

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/test-wasm...
test/mjsunit/wasm/test-wasm-module-builder.js:54: module.AddFunction("main",
[kAstI32, kAstI32, kAstI32])
weird indentation here. missing semicolon on the prev line?

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
File test/mjsunit/wasm/wasm-module-builder.js (right):

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:21:
WasmFunctionBuilder.prototype.ExportAs =
isn't JavaScript style lowerCamelCase?

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:38: this.signatures = new Array();
why not []?

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:38: this.signatures = new Array();
this.memory = null;

Otherwise it just magically appears. :)

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:52:
WasmModuleBuilder.prototype.AddSignature = function(sig) {
mention the expected type/format of sig?

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:106: bytes.push(new DataRef(string));
Neat trick, but why not just store the Ref in a separate list that you fix up
afterward? That way you don't have to iterate over bytes that you know aren't
StringRef or DataRefs.

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:131: if (debug) print("emiting memory @
" + bytes.length);
sp: emitting

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:143: for (var i = 0; i <
this.signatures.length; i++) {
for-of here too?

[titzer, 2016-03-05 01:26:23]

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/test-wasm...
File test/mjsunit/wasm/test-wasm-module-builder.js (right):

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/test-wasm...
test/mjsunit/wasm/test-wasm-module-builder.js:54: module.AddFunction("main",
[kAstI32, kAstI32, kAstI32])
On 2016/03/04 05:13:26, binji wrote:
> weird indentation here. missing semicolon on the prev line?

Good catch. Semicolon insertion to the rescue :-)

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
File test/mjsunit/wasm/wasm-module-builder.js (right):

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:38: this.signatures = new Array();
On 2016/03/04 05:13:26, binji wrote:
> this.memory = null;
> 
> Otherwise it just magically appears. :)

That's the JS way; M-O-O-N spells undefined!

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:52:
WasmModuleBuilder.prototype.AddSignature = function(sig) {
On 2016/03/04 05:13:26, binji wrote:
> mention the expected type/format of sig?

Done.

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:106: bytes.push(new DataRef(string));
On 2016/03/04 05:13:26, binji wrote:
> Neat trick, but why not just store the Ref in a separate list that you fix up
> afterward? That way you don't have to iterate over bytes that you know aren't
> StringRef or DataRefs.

I started doing that but it was getting unwieldy with four different lists and a
map for canonicalization, with the lists having positions, etc. Can do that in a
followup CL if necessary.

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:131: if (debug) print("emiting memory @
" + bytes.length);
On 2016/03/04 05:13:26, binji wrote:
> sp: emitting

Done.

https://codereview.chromium.org/1762203002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:143: for (var i = 0; i <
this.signatures.length; i++) {
On 2016/03/04 05:13:26, binji wrote:
> for-of here too?

Done.

[titzer, 2016-03-05 01:26:58]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-03-05 01:26:58]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1762203002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-05 01:27:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762203002/20001

[commit-bot: I haz the power, 2016-03-05 01:47:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-05 01:48:21]

Description was changed from

==========
[wasm] Add a JavaScript utility to make it easier to build WASM modules from
JavaScript.

R=binji@chromium.org,seththompson@chromium.org
BUG=
==========

to

==========
[wasm] Add a JavaScript utility to make it easier to build WASM modules from
JavaScript.

R=binji@chromium.org,seththompson@chromium.org
BUG=

Committed: https://crrev.com/d130c6bdc6a424b068614592a0b79a34750af0fc
Cr-Commit-Position: refs/heads/master@{#34513}
==========

[commit-bot: I haz the power, 2016-03-05 01:48:22]

Patchset 2 (id:??) landed as
https://crrev.com/d130c6bdc6a424b068614592a0b79a34750af0fc
Cr-Commit-Position: refs/heads/master@{#34513}

[adamk, 2016-03-05 02:20:32]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1771553002/ by adamk@chromium.org.

The reason for reverting is: New test test-wasm-module-builder fails on Linux -
shared bot:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/build....