Resynthesize codeOffset/codeLength properties.

Resynthesize codeOffset/codeLength properties.


R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9c7975283980baffe40910ecfb1d3e41517fb155

[Paul Berry, 2016-03-04 16:36:07]

https://codereview.chromium.org/1762193002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/fix_test.dart (right):

https://codereview.chromium.org/1762193002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/fix_test.dart:4335:
solo_test_undefinedMethod_create_BAD_inSDK() async {
Un-do this change before committing.

https://codereview.chromium.org/1762193002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1762193002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:744: int get codeLength;
Instead of adding these three getters to all these classes, I'd prefer if we
added a CodeRange class, e.g.:

abstract class CodeRange extends base.SummaryClass {
  @Id(1)
  int get length;
  @Id(0)
  int get offset;
}

abstract class UnlinkedClass extends base.SummaryClass {
  ...
  Id(13)
  CodeRange get codeRange;
}

This would let us eliminate the `hasCodeRange` bool (since the absence of a code
range would be represented by setting `codeRange` to `null`).  It would also
have the advantage of letting us get rid of all the `is` checks in
`buildCodeRange` and `serializeCodeRange` (they would be more like
`buildDocumentation` and `serializeDocumentation`).

https://codereview.chromium.org/1762193002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1762193002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1081: expect(cls.hasCodeRange,
true);
When would `hasCodeRange` be false?  We need tests for these cases.

[scheglov, 2016-03-04 17:15:19]

PTAL

https://codereview.chromium.org/1762193002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/fix_test.dart (right):

https://codereview.chromium.org/1762193002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/fix_test.dart:4335:
solo_test_undefinedMethod_create_BAD_inSDK() async {
On 2016/03/04 16:36:07, Paul Berry wrote:
> Un-do this change before committing.

Done.

https://codereview.chromium.org/1762193002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1762193002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:744: int get codeLength;
On 2016/03/04 16:36:07, Paul Berry wrote:
> Instead of adding these three getters to all these classes, I'd prefer if we
> added a CodeRange class, e.g.:
> 
> abstract class CodeRange extends base.SummaryClass {
>   @Id(1)
>   int get length;
>   @Id(0)
>   int get offset;
> }
> 
> abstract class UnlinkedClass extends base.SummaryClass {
>   ...
>   Id(13)
>   CodeRange get codeRange;
> }
> 
> This would let us eliminate the `hasCodeRange` bool (since the absence of a
code
> range would be represented by setting `codeRange` to `null`).  It would also
> have the advantage of letting us get rid of all the `is` checks in
> `buildCodeRange` and `serializeCodeRange` (they would be more like
> `buildDocumentation` and `serializeDocumentation`).

Good idea.
Thank you.

https://codereview.chromium.org/1762193002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1762193002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1081: expect(cls.hasCodeRange,
true);
On 2016/03/04 16:36:07, Paul Berry wrote:
> When would `hasCodeRange` be false?  We need tests for these cases.

In production - never.
It tests - for every manually created element.

[Paul Berry, 2016-03-04 17:19:58]

lgtm

[scheglov, 2016-03-04 17:26:35]

Description was changed from

==========
Resynthesize codeOffset/codeLength properties.


R=paulberry@google.com
BUG=
==========

to

==========
Resynthesize codeOffset/codeLength properties.


R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9c7975283980baffe40910ecfb1d3e41517fb155
==========

[scheglov, 2016-03-04 17:26:36]

Committed patchset #2 (id:20001) manually as
9c7975283980baffe40910ecfb1d3e41517fb155 (presubmit successful).