Base the right RegExp brand checks on Symbol.match

Base the right RegExp brand checks on Symbol.match

The ES2015 specification requires that String.prototype.startsWith,
String.prototype.endsWith and String.prototype.includes use the IsRegExp
internal algorithm to determine whether to throw a TypeError to prevent
a RegExp from being accidentally cast to a String for those methods.
That internal algorithm checks the presence/truthiness of Symbol.match
to make its determination. This patch switches the builtins to use
this correct test, rather than checking for the [[RegExpMatcher]]
internal slot as the builtins previously did.

R=yangguo

Committed: https://crrev.com/e99d292909f4a2ad055bfce16ce96018d816fa8f
Cr-Commit-Position: refs/heads/master@{#34547}

[Dan Ehrenberg, 2016-03-04 01:31:55]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 01:32:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762183002/1

[commit-bot: I haz the power, 2016-03-04 01:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 01:42:57]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16464)

[Dan Ehrenberg, 2016-03-04 01:56:08]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 01:56:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762183002/20001

[commit-bot: I haz the power, 2016-03-04 04:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 04:01:07]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-03-07 06:54:02]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-03-07 06:54:02]

LGTM. Are there any performance impacts?

Also, please send future reviews to my @chromium.org address, thanks.

[Dan Ehrenberg, 2016-03-07 15:38:21]

On 2016/03/07 at 06:54:02, yangguo wrote:
> LGTM. Are there any performance impacts?
> 
> Also, please send future reviews to my @chromium.org address, thanks.

I think this is relatively low risk. The new checks are already used in some
other important performance paths. Let's just let the perf bots complain. Sorry
about the address.

[Dan Ehrenberg, 2016-03-07 15:38:24]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-03-07 15:38:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762183002/20001

[commit-bot: I haz the power, 2016-03-07 16:04:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-07 16:06:01]

Description was changed from

==========
Base the right RegExp brand checks on Symbol.match

The ES2015 specification requires that String.prototype.startsWith,
String.prototype.endsWith and String.prototype.includes use the IsRegExp
internal algorithm to determine whether to throw a TypeError to prevent
a RegExp from being accidentally cast to a String for those methods.
That internal algorithm checks the presence/truthiness of Symbol.match
to make its determination. This patch switches the builtins to use
this correct test, rather than checking for the [[RegExpMatcher]]
internal slot as the builtins previously did.

R=yangguo
==========

to

==========
Base the right RegExp brand checks on Symbol.match

The ES2015 specification requires that String.prototype.startsWith,
String.prototype.endsWith and String.prototype.includes use the IsRegExp
internal algorithm to determine whether to throw a TypeError to prevent
a RegExp from being accidentally cast to a String for those methods.
That internal algorithm checks the presence/truthiness of Symbol.match
to make its determination. This patch switches the builtins to use
this correct test, rather than checking for the [[RegExpMatcher]]
internal slot as the builtins previously did.

R=yangguo

Committed: https://crrev.com/e99d292909f4a2ad055bfce16ce96018d816fa8f
Cr-Commit-Position: refs/heads/master@{#34547}
==========

[commit-bot: I haz the power, 2016-03-07 16:06:02]

Patchset 2 (id:??) landed as
https://crrev.com/e99d292909f4a2ad055bfce16ce96018d816fa8f
Cr-Commit-Position: refs/heads/master@{#34547}