Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1762143002: Use unique IDs for accessibility nodes on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix null obj deref in DCHECK Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 62b0b38f1815d6ba4c322c55d0ec2a3684f92878..5104a50027533c125510e89891da68a6c40be1a2 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -31,6 +31,7 @@
#include "base/sys_info.h"
#include "base/trace_event/trace_event.h"
#import "content/browser/accessibility/browser_accessibility_cocoa.h"
+#import "content/browser/accessibility/browser_accessibility_mac.h"
#include "content/browser/accessibility/browser_accessibility_manager_mac.h"
#include "content/browser/bad_message.h"
#import "content/browser/cocoa/system_hotkey_helper_mac.h"
@@ -2823,8 +2824,8 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
if (([attribute isEqualToString:NSAccessibilityChildrenAttribute] ||
[attribute isEqualToString:NSAccessibilityContentsAttribute]) &&
manager) {
- return [NSArray arrayWithObjects:manager->
- GetRoot()->ToBrowserAccessibilityCocoa(), nil];
+ return [NSArray arrayWithObjects:ToBrowserAccessibilityCocoa(
+ manager->GetRoot()), nil];
} else if ([attribute isEqualToString:NSAccessibilityRoleAttribute]) {
return NSAccessibilityScrollAreaRole;
}
@@ -2849,7 +2850,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
NSPoint localPoint = [self convertPoint:pointInWindow fromView:nil];
localPoint.y = NSHeight([self bounds]) - localPoint.y;
BrowserAccessibilityCocoa* root =
- manager->GetRoot()->ToBrowserAccessibilityCocoa();
+ ToBrowserAccessibilityCocoa(manager->GetRoot());
id obj = [root accessibilityHitTest:localPoint];
return obj;
}
@@ -2867,7 +2868,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
->GetRootBrowserAccessibilityManager();
// Only child is root.
if (manager &&
- manager->GetRoot()->ToBrowserAccessibilityCocoa() == child) {
+ ToBrowserAccessibilityCocoa(manager->GetRoot()) == child) {
return 0;
} else {
return NSNotFound;
@@ -2883,7 +2884,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
DCHECK(focused_item);
if (focused_item) {
BrowserAccessibilityCocoa* focused_item_cocoa =
- focused_item->ToBrowserAccessibilityCocoa();
+ ToBrowserAccessibilityCocoa(focused_item);
DCHECK(focused_item_cocoa);
if (focused_item_cocoa)
return focused_item_cocoa;
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/accessibility/platform/ax_platform_node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698