Chromium Code Reviews

Unified Diff: content/browser/accessibility/browser_accessibility_win.h

Issue 1762143002: Use unique IDs for accessibility nodes on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix null obj deref in DCHECK Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: content/browser/accessibility/browser_accessibility_win.h
diff --git a/content/browser/accessibility/browser_accessibility_win.h b/content/browser/accessibility/browser_accessibility_win.h
index adeb16b494be11ddfd180512c68892ed64cb7def..b237be91a4ea8261423be379e3bc0e6039035b27 100644
--- a/content/browser/accessibility/browser_accessibility_win.h
+++ b/content/browser/accessibility/browser_accessibility_win.h
@@ -97,10 +97,6 @@ BrowserAccessibilityWin
CONTENT_EXPORT ~BrowserAccessibilityWin() override;
- // The Windows-specific unique ID, used as the child ID for MSAA methods
- // like NotifyWinEvent, and as the unique ID for IAccessible2 and ISimpleDOM.
- LONG unique_id_win() const { return unique_id_win_; }
-
// Called after an atomic tree update completes. See
// BrowserAccessibilityManagerWin::OnAtomicUpdateFinished for more
// details on what these do.
@@ -867,11 +863,6 @@ BrowserAccessibilityWin
void AddRelations(ui::AXIntListAttribute src_attr,
const base::string16& iaccessiblerelation_type);
- // Windows-specific unique ID (unique within the browser process),
- // used for get_accChild, NotifyWinEvent, and as the unique ID for
- // IAccessible2 and ISimpleDOM.
- LONG unique_id_win_;
-
struct WinAttributes {
WinAttributes();
~WinAttributes();
@@ -918,9 +909,6 @@ BrowserAccessibilityWin
int previous_scroll_x_;
int previous_scroll_y_;
- // The next unique id to use.
- static LONG next_unique_id_win_;
-
// Give BrowserAccessibility::Create access to our constructor.
friend class BrowserAccessibility;
friend class BrowserAccessibilityRelation;
@@ -928,6 +916,12 @@ BrowserAccessibilityWin
DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityWin);
};
+CONTENT_EXPORT BrowserAccessibilityWin*
+ToBrowserAccessibilityWin(BrowserAccessibility* obj);
+
+CONTENT_EXPORT const BrowserAccessibilityWin*
+ToBrowserAccessibilityWin(const BrowserAccessibility* obj);
+
} // namespace content
#endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_WIN_H_

Powered by Google App Engine