Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 1762143002: Use unique IDs for accessibility nodes on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix null obj deref in DCHECK Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.cc
diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc
index 7bb165b62668ca110bd4bb4a272e67d45329ef66..ee3874abdbb25fe3e57265f802c01713b6d22564 100644
--- a/content/browser/accessibility/browser_accessibility.cc
+++ b/content/browser/accessibility/browser_accessibility.cc
@@ -15,9 +15,18 @@
#include "content/browser/accessibility/browser_accessibility_manager.h"
#include "content/common/accessibility_messages.h"
#include "ui/accessibility/ax_text_utils.h"
+#include "ui/accessibility/platform/ax_platform_node.h"
namespace content {
+namespace {
+
+// Map from unique_id to BrowserAccessibility
+using UniqueIDMap = base::hash_map<int32_t, BrowserAccessibility*>;
+base::LazyInstance<UniqueIDMap> g_unique_id_map = LAZY_INSTANCE_INITIALIZER;
+
+}
+
#if !defined(PLATFORM_HAS_NATIVE_ACCESSIBILITY_IMPL)
// static
BrowserAccessibility* BrowserAccessibility::Create() {
@@ -27,10 +36,23 @@ BrowserAccessibility* BrowserAccessibility::Create() {
BrowserAccessibility::BrowserAccessibility()
: manager_(NULL),
- node_(NULL) {
+ node_(NULL),
+ unique_id_(ui::AXPlatformNode::GetNextUniqueId()) {
+ g_unique_id_map.Get()[unique_id_] = this;
}
BrowserAccessibility::~BrowserAccessibility() {
+ if (unique_id_)
+ g_unique_id_map.Get().erase(unique_id_);
+}
+
+// static
+BrowserAccessibility* BrowserAccessibility::GetFromUniqueID(int32_t unique_id) {
+ auto iter = g_unique_id_map.Get().find(unique_id);
+ if (iter == g_unique_id_map.Get().end())
+ return nullptr;
+
+ return iter->second;
}
void BrowserAccessibility::Init(BrowserAccessibilityManager* manager,
@@ -594,6 +616,10 @@ void BrowserAccessibility::Destroy() {
node_ = NULL;
manager_ = NULL;
+ if (unique_id_)
+ g_unique_id_map.Get().erase(unique_id_);
+ unique_id_ = 0;
+
NativeReleaseReference();
}
« no previous file with comments | « content/browser/accessibility/browser_accessibility.h ('k') | content/browser/accessibility/browser_accessibility_auralinux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698