Use unique IDs for accessibility nodes on Android

content/browser/accessibility/browser_accessibility_auralinux.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_auralinux.h"
 
 #include <stdint.h>
 #include <string.h>
 
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/accessibility/browser_accessibility_manager_auralinux.h"
 #include "content/common/accessibility_messages.h"
 
 namespace content {
 
 static gpointer browser_accessibility_parent_class = NULL;
 
 static BrowserAccessibilityAuraLinux* ToBrowserAccessibilityAuraLinux(
     BrowserAccessibilityAtk* atk_object) {
   if (!atk_object)
     return NULL;
 
   return atk_object->m_object;
 }
 
+const BrowserAccessibilityAuraLinux* ToBrowserAccessibilityAuraLinux(
+    const BrowserAccessibility* obj) {
+  DCHECK(!obj || obj->IsNative());
+  return static_cast<const BrowserAccessibilityAuraLinux*>(obj);
+}
+
+BrowserAccessibilityAuraLinux* ToBrowserAccessibilityAuraLinux(
+    BrowserAccessibility* obj) {
+  DCHECK(!obj || obj->IsNative());
+  return static_cast<BrowserAccessibilityAuraLinux*>(obj);
+}
+
 //
 // AtkAction interface.
 //
 
 static BrowserAccessibilityAuraLinux* ToBrowserAccessibilityAuraLinux(
     AtkAction* atk_action) {
   if (!IS_BROWSER_ACCESSIBILITY(atk_action))
     return NULL;
 
   return ToBrowserAccessibilityAuraLinux(BROWSER_ACCESSIBILITY(atk_action));
@@ skipping 97 matching lines @@
 
   gfx::Point point(x, y);
   if (!obj->GetGlobalBoundsRect().Contains(point))
     return NULL;
 
   BrowserAccessibility* result = obj->BrowserAccessibilityForPoint(point);
   if (!result)
     return NULL;
 
   AtkObject* atk_result =
-      result->ToBrowserAccessibilityAuraLinux()->GetAtkObject();
+      ToBrowserAccessibilityAuraLinux(result)->GetAtkObject();
   g_object_ref(atk_result);
   return atk_result;
 }
 
 static void browser_accessibility_get_extents(AtkComponent* atk_component,
                                               gint* x,
                                               gint* y,
                                               gint* width,
                                               gint* height,
                                               AtkCoordType coord_type) {
@@ skipping 313 matching lines @@
 
   return obj->GetStringAttribute(ui::AX_ATTR_DESCRIPTION).c_str();
 }
 
 static AtkObject* browser_accessibility_get_parent(AtkObject* atk_object) {
   BrowserAccessibilityAuraLinux* obj =
       ToBrowserAccessibilityAuraLinux(atk_object);
   if (!obj)
     return NULL;
   if (obj->GetParent())
-    return obj->GetParent()->ToBrowserAccessibilityAuraLinux()->GetAtkObject();
+    return ToBrowserAccessibilityAuraLinux(obj->GetParent())->GetAtkObject();
 
   BrowserAccessibilityManagerAuraLinux* manager =
       static_cast<BrowserAccessibilityManagerAuraLinux*>(obj->manager());
   return manager->parent_object();
 }
 
 static gint browser_accessibility_get_n_children(AtkObject* atk_object) {
   BrowserAccessibilityAuraLinux* obj =
       ToBrowserAccessibilityAuraLinux(atk_object);
   if (!obj)
     return 0;
 
   return obj->PlatformChildCount();
 }
 
 static AtkObject* browser_accessibility_ref_child(AtkObject* atk_object,
                                                   gint index) {
   BrowserAccessibilityAuraLinux* obj =
       ToBrowserAccessibilityAuraLinux(atk_object);
   if (!obj)
     return NULL;
 
   if (index < 0 || index >= static_cast<gint>(obj->PlatformChildCount()))
     return NULL;
 
-  AtkObject* result = obj->InternalGetChild(index)
-                          ->ToBrowserAccessibilityAuraLinux()
-                          ->GetAtkObject();
+  AtkObject* result = ToBrowserAccessibilityAuraLinux(
+      obj->InternalGetChild(index))->GetAtkObject();
   g_object_ref(result);
   return result;
 }
 
 static gint browser_accessibility_get_index_in_parent(AtkObject* atk_object) {
   BrowserAccessibilityAuraLinux* obj =
       ToBrowserAccessibilityAuraLinux(atk_object);
   if (!obj)
     return 0;
   return obj->GetIndexInParent();
@@ skipping 212 matching lines @@
 
 void browser_accessibility_detach(BrowserAccessibilityAtk* atk_object) {
   atk_object->m_object = NULL;
 }
 
 // static
 BrowserAccessibility* BrowserAccessibility::Create() {
   return new BrowserAccessibilityAuraLinux();
 }
 
-const BrowserAccessibilityAuraLinux*
-BrowserAccessibility::ToBrowserAccessibilityAuraLinux() const {
-  return static_cast<const BrowserAccessibilityAuraLinux*>(this);
-}
-
-BrowserAccessibilityAuraLinux*
-BrowserAccessibility::ToBrowserAccessibilityAuraLinux() {
-  return static_cast<BrowserAccessibilityAuraLinux*>(this);
-}
-
 BrowserAccessibilityAuraLinux::BrowserAccessibilityAuraLinux()
     : atk_object_(NULL) {
 }
 
 BrowserAccessibilityAuraLinux::~BrowserAccessibilityAuraLinux() {
   browser_accessibility_detach(BROWSER_ACCESSIBILITY(atk_object_));
   if (atk_object_)
     g_object_unref(atk_object_);
 }
 
@@ skipping 17 matching lines @@
       atk_object_ = NULL;
     }
   }
 
   if (!atk_object_) {
     interface_mask_ = GetInterfaceMaskFromObject(this);
     atk_object_ = ATK_OBJECT(browser_accessibility_new(this));
     if (this->GetParent()) {
       atk_object_set_parent(
           atk_object_,
-          this->GetParent()->ToBrowserAccessibilityAuraLinux()->GetAtkObject());
+          ToBrowserAccessibilityAuraLinux(this->GetParent())->GetAtkObject());
     }
   }
 }
 
 bool BrowserAccessibilityAuraLinux::IsNative() const {
   return true;
 }
 
 void BrowserAccessibilityAuraLinux::InitRoleAndState() {
   switch (GetRole()) {
@@ skipping 137 matching lines @@
     case ui::AX_ROLE_TREE_ITEM:
       atk_role_ = ATK_ROLE_TREE_ITEM;
       break;
     default:
       atk_role_ = ATK_ROLE_UNKNOWN;
       break;
   }
 }
 
 }  // namespace content