Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 176213002: [Autofill] A bit of cleanup in autofill_agent.cc (Closed)

Created:
6 years, 10 months ago by Ilya Sherman
Modified:
6 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Autofill] A bit of cleanup in autofill_agent.cc BUG=none TEST=none R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Ilya Sherman
6 years, 10 months ago (2014-02-22 05:59:30 UTC) #1
Evan Stade
lgtm
6 years, 10 months ago (2014-02-24 18:53:37 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-24 18:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/176213002/1
6 years, 10 months ago (2014-02-24 18:59:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 19:10:14 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268931
6 years, 10 months ago (2014-02-24 19:10:14 UTC) #6
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-24 19:25:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/176213002/1
6 years, 10 months ago (2014-02-24 19:26:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/176213002/1
6 years, 10 months ago (2014-02-24 20:29:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/176213002/1
6 years, 10 months ago (2014-02-24 21:13:16 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 23:39:05 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=269262
6 years, 10 months ago (2014-02-24 23:39:05 UTC) #12
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-25 05:13:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/176213002/1
6 years, 10 months ago (2014-02-25 05:16:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/176213002/1
6 years, 10 months ago (2014-02-25 07:45:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/176213002/1
6 years, 10 months ago (2014-02-25 09:15:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/176213002/1
6 years, 10 months ago (2014-02-25 09:33:15 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 12:44:32 UTC) #18
Message was sent while issue was closed.
Change committed as 253137

Powered by Google App Engine
This is Rietveld 408576698