Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/scriptprocessornode-premature-death-expected.txt

Issue 1762103002: Keep ScriptProcessorNode from premature GC with ScriptWrappable::hasPendingActivity() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the manual test and fixed the exisiting automated test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/scriptprocessornode-premature-death-expected.txt
diff --git a/third_party/WebKit/LayoutTests/webaudio/scriptprocessornode-premature-death-expected.txt b/third_party/WebKit/LayoutTests/webaudio/scriptprocessornode-premature-death-expected.txt
index cc0a24fde832948970d5c740c663473f1564e161..ea5bedf79a6dca62e22e5bef7061c0aec83275d3 100644
--- a/third_party/WebKit/LayoutTests/webaudio/scriptprocessornode-premature-death-expected.txt
+++ b/third_party/WebKit/LayoutTests/webaudio/scriptprocessornode-premature-death-expected.txt
@@ -7,8 +7,8 @@ Testing with explicitly keeping a reference to the script processor node alive.
PASS wasCollectedPrematurely is false
PASS wasCalled is true
Testing without explicitly keeping a reference to the script processor node alive.
-FAIL wasCollectedPrematurely should be false. Was true.
-FAIL wasCalled should be true. Was false.
+PASS wasCollectedPrematurely is false
+PASS wasCalled is true
PASS successfullyParsed is true
TEST COMPLETE
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698