third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h - Issue 1762103002: Keep ScriptProcessorNode from premature GC with ScriptWrappable::hasPendingActivity()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

Issue 1762103002: Keep ScriptProcessorNode from premature GC with ScriptWrappable::hasPendingActivity() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/ManualTests/webaudio/scriptprocessornode-premature-gc.html ('k') | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h b/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

index dbb58cfde89c02ecfde1c1e92d158dad33351211..d86dc08633ebe65eb9dfee2223fed6b3ccaf1662 100644

--- a/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

@@ -106,6 +106,9 @@ public:

DEFINE_ATTRIBUTE_EVENT_LISTENER(audioprocess);

size_t bufferSize() const;

+ // ScriptWrappable

+ bool hasPendingActivity() const final;

haraken 2016/03/03 23:34:16 I'm not sure how this works. Don't you need to add

private:

ScriptProcessorNode(AbstractAudioContext&, float sampleRate, size_t bufferSize, unsigned numberOfInputChannels, unsigned numberOfOutputChannels);

};