Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: src/core/SkSpecialImage.h

Issue 1762013002: Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated (Closed) Base URL: https://skia.googlesource.com/skia.git@if-fragment
Patch Set: Fix bug Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkSpecialImage.h
diff --git a/src/core/SkSpecialImage.h b/src/core/SkSpecialImage.h
index 79fceeba6fc5c0ff52ae16d5dfa26039ee4ec9f7..069ff5362f8e0635d9bd26324fbee1419bb700f2 100644
--- a/src/core/SkSpecialImage.h
+++ b/src/core/SkSpecialImage.h
@@ -72,6 +72,13 @@ public:
static SkSpecialImage* internal_fromBM(SkImageFilter::Proxy*, const SkBitmap&);
SkImageFilter::Proxy* internal_getProxy();
+ // TODO: hide this when GrLayerHoister uses SkSpecialImages more fully
Stephen White 2016/03/04 15:55:05 Log a bug and reference it here?
robertphillips 2016/03/04 18:08:36 Done.
+ /**
+ * If the SpecialImage is backed by a gpu texture, return that texture.
+ * The active portion of the texture can be retrieved via 'subset'.
+ */
+ GrTexture* peekTexture() const;
+
protected:
SkSpecialImage(SkImageFilter::Proxy* proxy, const SkIRect& subset, uint32_t uniqueID)
: fSubset(subset)
@@ -96,11 +103,9 @@ protected:
*/
bool peekPixels(SkPixmap*) const;
- /**
- * If the SpecialImage is backed by a gpu texture, return that texture.
- * The active portion of the texture can be retrieved via 'subset'.
- */
- GrTexture* peekTexture() const;
+ // This entry point is for testing only. It does a readback from VRAM for
+ // GPU-backed special images.
+ bool getROPixels(SkBitmap*) const;
Stephen White 2016/03/04 15:55:05 getROPixelsForTesting(), then?
robertphillips 2016/03/04 18:08:36 Done - went with a prefix.
// TODO: remove this ASAP (see skbug.com/4965)
SkImageFilter::Proxy* proxy() const { return fProxy; }

Powered by Google App Engine
This is Rietveld 408576698