Issue 17620008: Include statistical profile into profviz.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17620008: Include statistical profile into profviz. (Closed)

Created:
7 years, 6 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Include statistical profile into profviz. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15456

Patch Set 2 : small tweak #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -44 lines)			Patch
M	tools/profviz/composer.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/profviz/profviz.css	View		2 chunks	+53 lines, -13 lines	1 comment	Download
M	tools/profviz/profviz.html	View		4 chunks	+35 lines, -13 lines	0 comments	Download
M	tools/profviz/profviz.js	View	1	8 chunks	+62 lines, -10 lines	0 comments	Download
M	tools/profviz/worker.js	View		5 chunks	+40 lines, -7 lines	0 comments	Download
M	tools/tickprocessor.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

CL includes: - Include a second view to display statistical profile produced by v8.log - ...

7 years, 6 months ago (2013-06-25 09:14:56 UTC) #1

Jakob Kummerow

LGTM (almost rubber-stamped, just did a quick pass). https://codereview.chromium.org/17620008/diff/3001/tools/profviz/profviz.css File tools/profviz/profviz.css (right): https://codereview.chromium.org/17620008/diff/3001/tools/profviz/profviz.css#newcode34 tools/profviz/profviz.css:34: background-color: ...

7 years, 5 months ago (2013-07-02 15:30:33 UTC) #2

Yang

7 years, 5 months ago (2013-07-02 15:34:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15456 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17620008: Include statistical profile into profviz. (Closed)

Description

Patch Set 1 #

Patch Set 2 : small tweak #

Messages