Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1761953002: Fix x86-64 Android build. (Closed)

Created:
4 years, 9 months ago by zra
Modified:
4 years, 9 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M runtime/bin/directory_android.cc View 1 2 chunks +1 line, -14 lines 1 comment Download
M runtime/vm/signal_handler_android.cc View 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
Still working on getting an AndroidX64 build of the standalone build going, but I can ...
4 years, 9 months ago (2016-03-03 18:54:04 UTC) #2
Cutch
lgtm
4 years, 9 months ago (2016-03-03 18:56:02 UTC) #3
Ivan Posva
LGTM -ip
4 years, 9 months ago (2016-03-03 19:05:28 UTC) #4
zra
4 years, 9 months ago (2016-03-03 19:11:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7c2c02d6a6e299124946672eeaf52b71fbd74d3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698