Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1761923002: Add JS tests for global const equality. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add JS tests for global const equality. Add these tests before fixing bug 419. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d8741afa1c3f31723ec62131d1bb8a78081cd1e4

Patch Set 1 #

Total comments: 4

Patch Set 2 : Typos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M testing/resources/javascript/consts.in View 1 2 chunks +11 lines, -0 lines 0 comments Download
M testing/resources/javascript/consts_expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Dan, quick review.
4 years, 9 months ago (2016-03-03 18:10:33 UTC) #2
dsinclair
lgtm https://codereview.chromium.org/1761923002/diff/1/testing/resources/javascript/consts.in File testing/resources/javascript/consts.in (right): https://codereview.chromium.org/1761923002/diff/1/testing/resources/javascript/consts.in#newcode72 testing/resources/javascript/consts.in:72: app.alert("Sting equality test (===): " + nit: String ...
4 years, 9 months ago (2016-03-03 18:12:50 UTC) #3
Tom Sepez
Committed patchset #2 (id:20001) manually as d8741afa1c3f31723ec62131d1bb8a78081cd1e4 (presubmit successful).
4 years, 9 months ago (2016-03-03 18:15:33 UTC) #5
Tom Sepez
4 years, 9 months ago (2016-03-03 18:15:34 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1761923002/diff/1/testing/resources/javascrip...
File testing/resources/javascript/consts.in (right):

https://codereview.chromium.org/1761923002/diff/1/testing/resources/javascrip...
testing/resources/javascript/consts.in:72: app.alert("Sting equality test (===):
" +
On 2016/03/03 18:12:50, dsinclair wrote:
> nit: String

Done.

https://codereview.chromium.org/1761923002/diff/1/testing/resources/javascrip...
File testing/resources/javascript/consts_expected.txt (right):

https://codereview.chromium.org/1761923002/diff/1/testing/resources/javascrip...
testing/resources/javascript/consts_expected.txt:110: Alert: Sting equality test
(===): true
On 2016/03/03 18:12:50, dsinclair wrote:
> nit: String

Done.

Powered by Google App Engine
This is Rietveld 408576698