[Extensions] Default-enable the toolbar redesign on trunk

[Extensions] Default-enable the toolbar redesign on trunk

BUG=514768
TBR=sky@chromium.org (trivial c/b/ui changes)

Committed: https://crrev.com/72b16f1710eadbb73f1ff64f056198360a74bd47
Cr-Commit-Position: refs/heads/master@{#379336}

[Devlin, 2016-03-04 02:58:08]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-03-04 02:58:09]

lazyboy@, mind taking a look?  Mostly just updating tests to explicitly disable
the feature if they're relying on legacy behavior.

[lazyboy, 2016-03-04 03:13:53]

https://codereview.chromium.org/1761913003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_action_icon_factory_unittest.cc
(right):

https://codereview.chromium.org/1761913003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_action_icon_factory_unittest.cc:214:
gfx::ImageSkia favicon = GetFavicon();
Remove?

https://codereview.chromium.org/1761913003/diff/20001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc (right):

https://codereview.chromium.org/1761913003/diff/20001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc:90:
use_redesign_(false) {}
Can this member be entirely removed?

Also, one of these constructors would also go away in that case.

[Devlin, 2016-03-04 03:36:41]

https://codereview.chromium.org/1761913003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_action_icon_factory_unittest.cc
(right):

https://codereview.chromium.org/1761913003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_action_icon_factory_unittest.cc:214:
gfx::ImageSkia favicon = GetFavicon();
On 2016/03/04 03:13:53, lazyboy wrote:
> Remove?

Done.

https://codereview.chromium.org/1761913003/diff/20001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc (right):

https://codereview.chromium.org/1761913003/diff/20001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc:90:
use_redesign_(false) {}
On 2016/03/04 03:13:53, lazyboy wrote:
> Can this member be entirely removed?
> 
> Also, one of these constructors would also go away in that case.

Nope, because the value is still used on line 100.

[lazyboy, 2016-03-04 19:22:51]

lgtm

[Devlin, 2016-03-04 19:26:32]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-03-04 19:26:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1761913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1761913003/40001

[commit-bot: I haz the power, 2016-03-04 19:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 19:38:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Devlin, 2016-03-04 19:41:03]

Description was changed from

==========
[Extensions] Default-enable the toolbar redesign on trunk

BUG=514768
==========

to

==========
[Extensions] Default-enable the toolbar redesign on trunk

BUG=514768
TBR=sky@chromium.org (trivial c/b/ui changes)
==========

[Devlin, 2016-03-04 19:41:15]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-03-04 19:41:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1761913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1761913003/40001

[commit-bot: I haz the power, 2016-03-04 19:47:19]

Description was changed from

==========
[Extensions] Default-enable the toolbar redesign on trunk

BUG=514768
TBR=sky@chromium.org (trivial c/b/ui changes)
==========

to

==========
[Extensions] Default-enable the toolbar redesign on trunk

BUG=514768
TBR=sky@chromium.org (trivial c/b/ui changes)
==========

[commit-bot: I haz the power, 2016-03-04 19:47:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-04 19:48:47]

Description was changed from

==========
[Extensions] Default-enable the toolbar redesign on trunk

BUG=514768
TBR=sky@chromium.org (trivial c/b/ui changes)
==========

to

==========
[Extensions] Default-enable the toolbar redesign on trunk

BUG=514768
TBR=sky@chromium.org (trivial c/b/ui changes)

Committed: https://crrev.com/72b16f1710eadbb73f1ff64f056198360a74bd47
Cr-Commit-Position: refs/heads/master@{#379336}
==========

[commit-bot: I haz the power, 2016-03-04 19:48:47]

Patchset 3 (id:??) landed as
https://crrev.com/72b16f1710eadbb73f1ff64f056198360a74bd47
Cr-Commit-Position: refs/heads/master@{#379336}