Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1761863002: [turbofan] Re-enables the jump table emission in the mips instruction selector. (Closed)

Created:
4 years, 9 months ago by epertoso
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Re-enables the jump table emission in the mips instruction selector. Changes MacroAssembler::GenerateSwitchTable to make sure that 'ra' is properly restored. BUG= Committed: https://crrev.com/a3a583dbaa79f22c1f9a8ad1dfd846c43d6ce9e2 Cr-Commit-Position: refs/heads/master@{#34460}

Patch Set 1 #

Patch Set 2 : Update. #

Patch Set 3 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -44 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +16 lines, -20 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +16 lines, -20 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
epertoso
4 years, 9 months ago (2016-03-03 13:47:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761863002/1
4 years, 9 months ago (2016-03-03 13:47:25 UTC) #5
Benedikt Meurer
LGTM modulo mips64.
4 years, 9 months ago (2016-03-03 13:57:56 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 14:05:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761863002/40001
4 years, 9 months ago (2016-03-03 14:20:08 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-03 14:38:30 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 14:38:53 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3a583dbaa79f22c1f9a8ad1dfd846c43d6ce9e2
Cr-Commit-Position: refs/heads/master@{#34460}

Powered by Google App Engine
This is Rietveld 408576698