Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/Init.cpp

Issue 1761853002: Shut down all threads before the main thread shuts down (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/Init.h ('k') | third_party/WebKit/Source/modules/InitModules.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/Init.cpp
diff --git a/third_party/WebKit/Source/core/Init.cpp b/third_party/WebKit/Source/core/Init.cpp
index 886a98232d478e10dd1da5db69daf24fcd9260b4..056121830cd5b026244838e0f599b8fa1fc855b9 100644
--- a/third_party/WebKit/Source/core/Init.cpp
+++ b/third_party/WebKit/Source/core/Init.cpp
@@ -74,8 +74,8 @@ void CoreInitializer::registerEventFactory()
void CoreInitializer::init()
{
- ASSERT(!m_isInited);
- m_isInited = true;
+ ASSERT(!isInitialized());
+ m_isInitialized = true;
// Note: in order to add core static strings for a new module (1)
// the value of 'coreStaticStringsCount' must be updated with the
// added strings count, (2) if the added strings are quialified names
@@ -143,17 +143,14 @@ void CoreInitializer::init()
ScriptStreamerThread::init();
}
-void CoreInitializer::terminateThreads()
+void CoreInitializer::shutdown()
{
// Make sure we stop the HTMLParserThread before Platform::current() is
// cleared.
+ ASSERT(Platform::current());
HTMLParserThread::shutdown();
WorkerThread::terminateAndWaitForAllWorkers();
}
-void CoreInitializer::shutdown()
-{
-}
-
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/Init.h ('k') | third_party/WebKit/Source/modules/InitModules.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698