Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Issue 17618003: mac: Remove ScopedCFTypeRef from base::mac::. (Closed)

Created:
7 years, 6 months ago by Nico
Modified:
7 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

mac: Remove ScopedCFTypeRef from base::mac::. Most references were updated from base::mac:: to base:: in r208245. Manually fix up a few stragglers in this CL too. BUG=251957 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208287

Patch Set 1 #

Patch Set 2 : base #

Patch Set 3 : ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M base/files/file_path.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/mac/scoped_cftyperef.h View 1 chunk +0 lines, -6 lines 0 comments Download
M base/message_loop/message_pump_io_ios.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
If a few new uses of base::mac::ScopedCFTypeRef snuck in (the bots will tell me), I'll ...
7 years, 6 months ago (2013-06-24 19:05:25 UTC) #1
Mark Mentovai
LGTM (Did clang-format have anything to do with this one? ’Cuz the formatting here doesn’t ...
7 years, 6 months ago (2013-06-24 19:14:36 UTC) #2
Nico
On Mon, Jun 24, 2013 at 12:14 PM, <mark@chromium.org> wrote: > LGTM > > (Did ...
7 years, 6 months ago (2013-06-24 19:16:21 UTC) #3
Mark Mentovai
Yeah, that’s what I thought.
7 years, 6 months ago (2013-06-24 19:19:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/17618003/4001
7 years, 6 months ago (2013-06-24 19:46:22 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-24 20:12:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/17618003/25001
7 years, 6 months ago (2013-06-24 22:45:24 UTC) #7
Nico
7 years, 6 months ago (2013-06-24 23:14:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r208287.

Powered by Google App Engine
This is Rietveld 408576698