Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1761793005: [Media Router] Do not issue a tab mirroring sinks query if tab is not valid. (Closed)

Created:
4 years, 9 months ago by imcheng
Modified:
4 years, 9 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Do not issue a tab mirroring sinks query if tab is not valid. It is possible to bring up the MR UI outside the context of a valid tab. In those cases we should omit TAB_MIRROR is one of the cast modes and not start a sinks query for the tab mirror MediaSource. BUG=591855 Committed: https://crrev.com/236fddad6b5bcd9d00ead4c19d18e6fbd459d143 Cr-Commit-Position: refs/heads/master@{#379872}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
imcheng
PTAL
4 years, 9 months ago (2016-03-04 18:56:53 UTC) #2
apacible
lgtm
4 years, 9 months ago (2016-03-07 18:01:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761793005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761793005/20001
4 years, 9 months ago (2016-03-08 18:03:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 18:50:50 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 18:52:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/236fddad6b5bcd9d00ead4c19d18e6fbd459d143
Cr-Commit-Position: refs/heads/master@{#379872}

Powered by Google App Engine
This is Rietveld 408576698