Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1761793004: [DevTools] Fix crash in InspectorTracingAgent. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix crash in InspectorTracingAgent. |m_state| can be null at the time we call setLayerTreeId. BUG=591622 Committed: https://crrev.com/b6eceb74841afe66e73115c84317b3bbe29b124f Cr-Commit-Position: refs/heads/master@{#379174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-03-03 20:48:40 UTC) #2
caseq
lgtm
4 years, 9 months ago (2016-03-04 00:38:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761793004/1
4 years, 9 months ago (2016-03-04 00:39:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 01:53:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 01:54:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6eceb74841afe66e73115c84317b3bbe29b124f
Cr-Commit-Position: refs/heads/master@{#379174}

Powered by Google App Engine
This is Rietveld 408576698