Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1761743003: [Media Router] Take search input into account when updating element positioning. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Take search input into account when updating element positioning. This change fixes the following: - the positioning and overlap issue with a long sink list - ensure the search input always appears at the bottom of the dialog when not in filter mode BUG=591567 Committed: https://crrev.com/acbfb0178f3a20e386ff2bb10d6af9faa17ca316 Cr-Commit-Position: refs/heads/master@{#379132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
apacible
PTAL, thanks!
4 years, 9 months ago (2016-03-03 03:16:17 UTC) #3
imcheng
lgtm
4 years, 9 months ago (2016-03-03 21:38:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761743003/1
4 years, 9 months ago (2016-03-03 22:14:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 23:18:09 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 23:19:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acbfb0178f3a20e386ff2bb10d6af9faa17ca316
Cr-Commit-Position: refs/heads/master@{#379132}

Powered by Google App Engine
This is Rietveld 408576698