Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1761693002: Removed unnecessary resolverChanged call. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+prerender_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unnecessary resolverChanged call. Changing disabled state of a stylesheet link caused active stylesheet update to happen twice. Once from setDisabled() on the stylesheet and once directly from LinkStyle::setDisabledState(). Removed the one called directly from LinkStyle::setDisabledState. R=esprehn@chromium.org BUG=591559 Committed: https://crrev.com/6e55b820ed9915e639871fbe83c9e49712d8e239 Cr-Commit-Position: refs/heads/master@{#378922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761693002/1
4 years, 9 months ago (2016-03-03 00:18:16 UTC) #2
rune
ptal
4 years, 9 months ago (2016-03-03 00:20:16 UTC) #3
esprehn
lgtm
4 years, 9 months ago (2016-03-03 00:20:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 01:57:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761693002/1
4 years, 9 months ago (2016-03-03 02:19:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 02:25:37 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 02:26:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e55b820ed9915e639871fbe83c9e49712d8e239
Cr-Commit-Position: refs/heads/master@{#378922}

Powered by Google App Engine
This is Rietveld 408576698