Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1761663003: Revert of [DevTools] Postpone more agents instantiation until attached. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ ) Reason for revert: Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406 Original issue's description: > [DevTools] Postpone more agents instantiation until attached. > > To support multiple attached devtools, we have to instantiate > individual agents on demand, rather than on creation. > This patch moves most of agents, with only worker and inspector to go. > > BUG=590878 > > Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 > Cr-Commit-Position: refs/heads/master@{#378509} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=590878 Committed: https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c Cr-Commit-Position: refs/heads/master@{#379111}

Patch Set 1 #

Patch Set 2 : manual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -80 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 1 4 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 1 4 chunks +15 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 8 chunks +30 lines, -43 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Created Revert of [DevTools] Postpone more agents instantiation until attached.
4 years, 9 months ago (2016-03-03 19:25:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761663003/1
4 years, 9 months ago (2016-03-03 19:26:26 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/139878) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-03 19:29:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761663003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761663003/260001
4 years, 9 months ago (2016-03-03 21:03:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:260001)
4 years, 9 months ago (2016-03-03 22:18:25 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 22:19:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c
Cr-Commit-Position: refs/heads/master@{#379111}

Powered by Google App Engine
This is Rietveld 408576698