Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 1761643002: Use installed vulkan SDK and remove checked in SDK (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@sc2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3955 lines) Patch
M gyp/gpu.gyp View 1 1 chunk +15 lines, -53 lines 0 comments Download
D third_party/vulkan/vk_platform.h View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/vulkan/vulkan.h View 1 chunk +0 lines, -3775 lines 0 comments Download
D third_party/vulkan/vulkan-1.lib View Binary file 0 comments Download

Messages

Total messages: 17 (9 generated)
bsalomon
4 years, 9 months ago (2016-03-02 23:22:40 UTC) #3
egdaniel
lgtm. Out of curiosity are you able to run vulkan on your win machine now?
4 years, 9 months ago (2016-03-02 23:31:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761643002/1
4 years, 9 months ago (2016-03-03 00:09:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/6722) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
4 years, 9 months ago (2016-03-03 00:10:32 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761643002/1
4 years, 9 months ago (2016-03-03 23:58:49 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6740)
4 years, 9 months ago (2016-03-04 00:00:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761643002/20001
4 years, 9 months ago (2016-03-04 00:23:30 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 00:38:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f98bc6d618fb7317abff05b3b4351ff24e4fb560

Powered by Google App Engine
This is Rietveld 408576698