third_party/WebKit/Source/core/html/HTMLDialogElement.cpp - Issue 1761633002: One accessibility tree per frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

Issue 1761633002: One accessibility tree per frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix is-richly-editable test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp b/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

index 0e8687903ee022c90a0614b2199214aaf7b5df8d..953a6cee67fd65357c0cf4c7207e20a117f0eff2 100644

--- a/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

@@ -84,10 +84,9 @@ static void inertSubtreesChanged(Document& document)

// tree can change inertness which means they must be added or removed from

// the tree. The most foolproof way is to clear the entire tree and rebuild

// it, though a more clever way is probably possible.

- Document& topDocument = document.topDocument();

- topDocument.clearAXObjectCache();

- if (AXObjectCache* cache = topDocument.axObjectCache())

- cache->childrenChanged(&topDocument);

+ document.clearAXObjectCache();

+ if (AXObjectCache* cache = document.axObjectCache())

+ cache->childrenChanged(&document);

}

inline HTMLDialogElement::HTMLDialogElement(Document& document)