Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1826)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 1761633002: One accessibility tree per frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix is-richly-editable test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/common/accessibility_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index b50408eaebb12fa5dcde62aa30d9ad66412a2132..df811e675a23234796a136c050118b69eae662ce 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -1608,19 +1608,12 @@ void RenderWidgetHostViewAndroid::OnSetNeedsFlushInput() {
BrowserAccessibilityManager*
RenderWidgetHostViewAndroid::CreateBrowserAccessibilityManager(
BrowserAccessibilityDelegate* delegate) {
- // TODO(dmazzoni): Currently there can only be one
- // BrowserAccessibilityManager per ContentViewCore, so return NULL
- // if there's already a BrowserAccessibilityManager for the main
- // frame. Eventually, in order to support cross-process iframes on
- // Android we'll need to add support for a
- // BrowserAccessibilityManager for a child frame.
- // http://crbug.com/423846
- if (!host_ || host_->GetRootBrowserAccessibilityManager())
- return NULL;
-
base::android::ScopedJavaLocalRef<jobject> obj;
- if (content_view_core_)
+ if (host_ &&
+ host_->GetRootBrowserAccessibilityManager() &&
+ content_view_core_) {
obj = content_view_core_->GetJavaObject();
+ }
return new BrowserAccessibilityManagerAndroid(
obj,
BrowserAccessibilityManagerAndroid::GetEmptyDocument(),
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/common/accessibility_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698