Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 17616006: Add a test for ITunesDataProvider. (Closed)

Created:
7 years, 6 months ago by vandebo (ex-Chrome)
Modified:
7 years, 5 months ago
Reviewers:
Lei Zhang, Greg Billock
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Add a test for ITunesDataProvider. It's a browser test instead of a unit test because the utility process gets invoked. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209868

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Works #

Total comments: 12

Patch Set 6 : Address comments #

Total comments: 1

Patch Set 7 : Compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -0 lines) Patch
A chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc View 1 2 3 4 5 6 1 chunk +333 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_finder_win_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vandebo (ex-Chrome)
7 years, 5 months ago (2013-07-02 20:04:15 UTC) #1
Greg Billock
lgtm. a few comments, but seems fine. https://codereview.chromium.org/17616006/diff/9001/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc File chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc (right): https://codereview.chromium.org/17616006/diff/9001/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc#newcode77 chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc:77: int id ...
7 years, 5 months ago (2013-07-02 20:29:56 UTC) #2
vandebo (ex-Chrome)
+thestig for gypi changes. https://codereview.chromium.org/17616006/diff/9001/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc File chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc (right): https://codereview.chromium.org/17616006/diff/9001/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc#newcode77 chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc:77: int id = static_cast<int>(i) + ...
7 years, 5 months ago (2013-07-02 21:00:31 UTC) #3
Lei Zhang
gypi file lgtm
7 years, 5 months ago (2013-07-02 21:25:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/17616006/13001
7 years, 5 months ago (2013-07-02 21:26:34 UTC) #5
vandebo (ex-Chrome)
Compile fix
7 years, 5 months ago (2013-07-02 22:27:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/17616006/29002
7 years, 5 months ago (2013-07-02 22:27:50 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-03 03:44:41 UTC) #8
Message was sent while issue was closed.
Change committed as 209868

Powered by Google App Engine
This is Rietveld 408576698