Handle AccessorPair struct in heap snapshot.

Handle AccessorPair struct in heap snapshot.

R=svenpanne@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15320

[alph, 2013-06-24 18:18:54]

Folks, could you please take a look. Thanks!

[yurys, 2013-06-24 19:00:37]

not lgtm, now that we have a reproduction case for this issue there should be a
test.

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1249: if (Object* getter = accessors->getter()) {
Can this ever be NULL?

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1253: if (Object* setter = accessors->setter()) {
And this? I'd think that it is either oddball or some object as both fields are
initialized with OddBall values in
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/heap.cc&q=A...

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1415: if (getter && !getter->IsOddball()) {
Ditto.

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1419: if (setter && !setter->IsOddball()) {
Ditto.

[alph, 2013-06-25 11:38:45]

PTAL

[alph, 2013-06-25 11:39:36]

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1249: if (Object* getter = accessors->getter()) {
On 2013/06/24 19:00:37, Yury Semikhatsky wrote:
> Can this ever be NULL?

Done.

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1253: if (Object* setter = accessors->setter()) {
On 2013/06/24 19:00:37, Yury Semikhatsky wrote:
> And this? I'd think that it is either oddball or some object as both fields
are
> initialized with OddBall values in
>
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/heap.cc&q=A...

Done.

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1415: if (getter && !getter->IsOddball()) {
On 2013/06/24 19:00:37, Yury Semikhatsky wrote:
> Ditto.

Done.

https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1419: if (setter && !setter->IsOddball()) {
On 2013/06/24 19:00:37, Yury Semikhatsky wrote:
> Ditto.

Done.

[yurys, 2013-06-25 11:44:46]

lgtm

[Sven Panne, 2013-06-25 11:53:52]

lgtm

[alph, 2013-06-25 11:55:48]

Committed patchset #2 manually as r15320 (presubmit successful).