Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1761593003: Revert "Speed up the LookupIterator" (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr., Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Speed up the LookupIterator" This reverts commit 2608ecc7157a9d6d482709fc197b2fc0317d9d09. Revert "Specialize helper methods in the LookupIterator by is_element." This reverts commit 6eb483f8782e32d32f75d091fea4b50846210372. Revert "Avoid SetPropertyInternal if the LookupIterator is NotFound" This reverts commit ca5bd8d4a9d91336d770668dc569661e4fba5aa3. Revert "Inline fast-bailout-checks for LookupIterator::UpdateProtector" This reverts commit d98570a1eb7f017ca6ecc9d79236456f2691aee3. This breaks layout tests with timeouts: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5060 It also seems to break jsfunfuzz: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/7930 The other three CLs are reverted to be able to revert the first. BUG=v8:4798 LOG=n TBR=verwaest@chromium.org Committed: https://crrev.com/70ac41a84a1dbb2025bb447a81582146ceb2a5ff Cr-Commit-Position: refs/heads/master@{#34457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -233 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api-natives.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/lookup.h View 7 chunks +27 lines, -52 lines 0 comments Download
M src/lookup.cc View 17 chunks +108 lines, -131 lines 0 comments Download
M src/objects.h View 5 chunks +7 lines, -10 lines 0 comments Download
M src/objects.cc View 7 chunks +16 lines, -21 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/types.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Achenbach
TBR
4 years, 9 months ago (2016-03-03 07:41:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761593003/1
4 years, 9 months ago (2016-03-03 07:41:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11821)
4 years, 9 months ago (2016-03-03 07:47:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761593003/1
4 years, 9 months ago (2016-03-03 08:08:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 08:10:50 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 08:12:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70ac41a84a1dbb2025bb447a81582146ceb2a5ff
Cr-Commit-Position: refs/heads/master@{#34457}

Powered by Google App Engine
This is Rietveld 408576698