Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

Issue 1761533002: [Offline pages] Adding test for OfflinePageUtils#stripSchemeFromOnlineUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
index 2d3c48d951cea0d10bb01cda425152180f7c7fc0..647895ae109471cf368923ee7d5ff8834b655d12 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
@@ -66,6 +66,27 @@ public class OfflinePageUtilsTest {
assertTrue(OfflinePageUtils.isStorageAlmostFull());
}
+ @Test
+ @Feature({"OfflinePages"})
+ public void testStripSchemeFromOnlineUrl() {
+ // Only scheme gets stripped.
+ assertEquals("cs.chromium.org",
+ OfflinePageUtils.stripSchemeFromOnlineUrl("https://cs.chromium.org"));
+ assertEquals("cs.chromium.org",
+ OfflinePageUtils.stripSchemeFromOnlineUrl("http://cs.chromium.org"));
+ // If there is no scheme, nothing changes.
+ assertEquals("cs.chromium.org",
+ OfflinePageUtils.stripSchemeFromOnlineUrl("cs.chromium.org"));
+ // Path is not touched/changed.
+ String urlWithPath = "code.google.com/p/chromium/codesearch#search"
+ + "/&q=offlinepageutils&sq=package:chromium&type=cs";
+ assertEquals(urlWithPath,
+ OfflinePageUtils.stripSchemeFromOnlineUrl("https://" + urlWithPath));
+ // Beginning and ending spaces get trimmed.
+ assertEquals("cs.chromium.org",
+ OfflinePageUtils.stripSchemeFromOnlineUrl(" https://cs.chromium.org "));
+ }
+
/** A shadow/wrapper of android.os.Environment that allows injecting a test directory. */
@Implements(Environment.class)
public static class WrappedEnvironment {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698