Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 17615006: Remove V8Collection.{h,cpp} (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index a21c25921389f856fbf4708f8ec1e16275e5a23e..9f5e9ecfcbb1bfab4922c21e7adc932d868a988d 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -3211,7 +3211,7 @@ sub GenerateImplementationIndexedPropertyAccessors
$code .= $indexedSetterFunction ? ", ${implClassName}V8Internal::indexedPropertySetterCallback" : ", 0";
$code .= ", 0"; # IndexedPropertyQuery -- not being used at the moment.
$code .= $indexedDeleterFunction ? ", ${implClassName}V8Internal::indexedPropertyDeleterCallback" : ", 0";
- $code .= ", nodeCollectionIndexedPropertyEnumerator<${implClassName}>" if $indexedEnumeratorFunction;
+ $code .= ", indexedPropertyEnumerator<${implClassName}>" if $indexedEnumeratorFunction;
$code .= ");\n";
}
@@ -3226,7 +3226,6 @@ sub GenerateImplementationIndexedPropertyGetter
my $v8ClassName = GetV8ClassName($interface);
my $methodName = GetImplName($indexedGetterFunction);
- AddToImplIncludes("bindings/v8/V8Collection.h");
my $returnType = $indexedGetterFunction->type;
my $nativeType = GetNativeType($returnType);
my $nativeValue = "element";
@@ -3323,7 +3322,6 @@ sub GenerateImplementationIndexedPropertySetter
my $v8ClassName = GetV8ClassName($interface);
my $methodName = GetImplName($indexedSetterFunction);
- AddToImplIncludes("bindings/v8/V8Collection.h");
my $type = $indexedSetterFunction->parameters->[1]->type;
my $raisesExceptions = $indexedSetterFunction->extendedAttributes->{"RaisesException"};
my $treatNullAs = $indexedSetterFunction->parameters->[1]->extendedAttributes->{"TreatNullAs"};
@@ -3572,7 +3570,6 @@ sub GenerateImplementationNamedPropertyGetter
my $v8ClassName = GetV8ClassName($interface);
my $methodName = GetImplName($namedGetterFunction);
- AddToImplIncludes("bindings/v8/V8Collection.h");
my $returnType = $namedGetterFunction->type;
my $isNull = GenerateIsNullExpression($returnType, "element");
my $nativeValue = "element";
@@ -3653,7 +3650,6 @@ sub GenerateImplementationNamedPropertySetter
my $v8ClassName = GetV8ClassName($interface);
my $methodName = GetImplName($namedSetterFunction);
- AddToImplIncludes("bindings/v8/V8Collection.h");
my $raisesExceptions = $namedSetterFunction->extendedAttributes->{"RaisesException"};
my $treatNullAs = $namedSetterFunction->parameters->[1]->extendedAttributes->{"TreatNullAs"};
my $treatUndefinedAs = $namedSetterFunction->parameters->[1]->extendedAttributes->{"TreatUndefinedAs"};
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698