Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 17615006: Remove V8Collection.{h,cpp} (Closed)

Created:
7 years, 6 months ago by haraken
Modified:
7 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use, kojih
Visibility:
Public.

Description

Remove V8Collection.{h,cpp} - Removed unused methods. - Moved nodeCollectionIndexedPropertyEnumerator to V8Binding.h and renamed it to indexedPropertyEnumerator. This method will be embedded into the generated code in the next CL. R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152992

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -151 lines) Patch
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 5 chunks +1 line, -5 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
D Source/bindings/v8/V8Collection.h View 1 chunk +0 lines, -80 lines 0 comments Download
D Source/bindings/v8/V8Collection.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
haraken
r?
7 years, 6 months ago (2013-06-25 01:30:18 UTC) #1
abarth-chromium
lgtm
7 years, 6 months ago (2013-06-25 04:53:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/17615006/1
7 years, 6 months ago (2013-06-25 05:00:55 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-25 05:14:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/17615006/12001
7 years, 6 months ago (2013-06-25 05:19:57 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 06:28:50 UTC) #6
Message was sent while issue was closed.
Change committed as 152992

Powered by Google App Engine
This is Rietveld 408576698