Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1761473002: Get Vk compiling post-MIP map changes (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@shaderc
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -136 lines) Patch
M src/gpu/vk/GrVkGpu.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 5 chunks +12 lines, -9 lines 0 comments Download
M src/gpu/vk/GrVkTexture.cpp View 1 chunk +124 lines, -124 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
bsalomon
4 years, 9 months ago (2016-03-02 17:24:18 UTC) #3
jvanverth1
lgtm
4 years, 9 months ago (2016-03-02 18:41:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761473002/1
4 years, 9 months ago (2016-03-02 18:45:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/850)
4 years, 9 months ago (2016-03-02 18:47:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761473002/1
4 years, 9 months ago (2016-03-02 18:57:06 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 18:58:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a1e6b3be8124cef85f2e39e3cb85000ad9526d48

Powered by Google App Engine
This is Rietveld 408576698