get skia port working again

pdfium.gyp

 # Copyright 2015 PDFium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # TODO(thakis): Enable this, pdfium:29
     #'chromium_code': 1,
     'pdf_use_skia%': 0,
     'pdf_enable_v8%': 1,
@@ skipping 537 matching lines @@
       ],
       'variables': {
         'clang_warning_flags': [
           # http://code.google.com/p/pdfium/issues/detail?id=188
           '-Wno-switch',
         ],
       },
       'conditions': [
         ['pdf_use_skia==1', {
           'sources': [
-            'core/src/fxge/skia/fx_skia_blitter_new.cpp',
             'core/src/fxge/skia/fx_skia_device.cpp',
           ],
           'dependencies': [
             '<(DEPTH)/skia/skia.gyp:skia',
           ],
           'include_dirs': [

[dsinclair, 2016/03/03 18:40:11]

These should probably be removed and we do third_party/skia/include/... in the
code.

[caryclark, 2016/03/03 21:03:44]

Done.

             '<(DEPTH)/third_party/skia/include/config',
             '<(DEPTH)/third_party/skia/include/core',
             '<(DEPTH)/third_party/skia/include/effects',
             '<(DEPTH)/third_party/skia/include/images',

[dsinclair, 2016/03/03 18:40:11]

Out of curiosity, did you check the skia dir out manually? I don't seem to have
one in my checkout? Do we need to add skia to DEPS?

[caryclark, 2016/03/03 21:03:44]

I am doing the build inside a Chromium tree for now. I couldn't figure out a way
to easily do it in a standalone PDFium tree.

To test, I use:
GYP_DEFINES="pdf_use_skia=1" ./build/gyp_chromium -Dcomponent=shared_library
ninja -C out/Debug pdfium_test 
./out/Debug/pdfium_test --png /some/local/pdf/file

An aside: I have the new/delete mismatch with non-shared library builds as well.

-            '<(DEPTH)/third_party/skia/include/lazy',
-            '<(DEPTH)/third_party/skia/include/pathops',
-            '<(DEPTH)/third_party/skia/include/utils',
-            '<(DEPTH)/third_party/skia/src/core',
           ],
         }],
         ['OS=="win"', {
           'defines!': [
             'WIN32_LEAN_AND_MEAN'
           ],
           'sources': [
             'core/src/fxge/win32/dwrite_int.h',
             'core/src/fxge/win32/fx_win32_device.cpp',
             'core/src/fxge/win32/fx_win32_dib.cpp',
@@ skipping 293 matching lines @@
             'fpdfsdk/include/fpdfxfa/fpdfxfa_app.h',
             'fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h',
             'fpdfsdk/include/fpdfxfa/fpdfxfa_page.h',
             'fpdfsdk/include/fpdfxfa/fpdfxfa_util.h',
           ],
         },
       ]
     }],
   ]
 }