[MD] simplify and unify some ink drop center calculations

ui/views/controls/button/label_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/label_button.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 402 matching lines @@
 }
 
 void LabelButton::RemoveInkDropLayer(ui::Layer* ink_drop_layer) {
   image()->SetPaintToLayer(false);
   ink_drop_container_->layer()->Remove(ink_drop_layer);
   ink_drop_container_->SetVisible(false);
 }
 
 scoped_ptr<views::InkDropAnimation> LabelButton::CreateInkDropAnimation()
     const {
-  // TODO(bruthig): Make the flood fill ink drops centered on the LocatedEvent
-  // that triggered them.
   return GetText().empty()
              ? CustomButton::CreateInkDropAnimation()
              : make_scoped_ptr(new views::FloodFillInkDropAnimation(
                    size(), GetInkDropCenter(), GetInkDropBaseColor()));
 }
 
 scoped_ptr<views::InkDropHover> LabelButton::CreateInkDropHover() const {
   if (!ShouldShowInkDropHover())
     return nullptr;
   return GetText().empty()
              ? CustomButton::CreateInkDropHover()
              : make_scoped_ptr(new views::InkDropHover(
                    size(), 0, GetInkDropCenter(), GetInkDropBaseColor()));
 }
 
+gfx::Point LabelButton::GetInkDropCenter() const {
+  // TODO(bruthig): Make the flood fill ink drops centered on the LocatedEvent
+  // that triggered them.
+  return GetText().empty() ? image()->bounds().CenterPoint()

[varkha, 2016/03/03 05:51:47]

I think you need to do something like this:
  gfx::Point center = image()->bounds().CenterPoint();
  center.set_x(GetMirroredXInView(center.x()));
and then use |center| in place of |image()->bounds().CenterPoint()|.
Please try it with maximized and not maximized browser window with --lang=he as
well as English layout.

+                           : CustomButton::GetInkDropCenter();
+}
+
 void LabelButton::StateChanged() {
   const gfx::Size previous_image_size(image_->GetPreferredSize());
   UpdateImage();
   const SkColor color = button_state_colors_[state()];
   if (state() != STATE_DISABLED && label_->enabled_color() != color)
     label_->SetEnabledColor(color);
   label_->SetEnabled(state() != STATE_DISABLED);
   if (image_->GetPreferredSize() != previous_image_size)
     Layout();
 }
@@ skipping 112 matching lines @@
   GetExtraParams(params);
   return ui::NativeTheme::kHovered;
 }
 
 void LabelButton::ResetCachedPreferredSize() {
   cached_preferred_size_valid_ = false;
   cached_preferred_size_ = gfx::Size();
 }
 
 }  // namespace views