Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1761383002: [Android] Restrict tests inheriting from DocumentModeTestBase to phones. (Closed)

Created:
4 years, 9 months ago by jbudorick
Modified:
4 years, 9 months ago
Reviewers:
Yaron, Nico, newt (away)
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Restrict tests inheriting from DocumentModeTestBase to phones. BUG=589663 Committed: https://crrev.com/acf0dd8e8dbf43d03330609890cbdf2334e14c02 Cr-Commit-Position: refs/heads/master@{#380307}

Patch Set 1 #

Total comments: 4

Patch Set 2 : newt question #

Total comments: 2

Patch Set 3 : newt comments 2 #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+503 lines, -100 lines) Patch
M base/BUILD.gn View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M base/base.gyp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java View 1 2 3 2 chunks +3 lines, -98 lines 0 comments Download
A base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java View 1 chunk +47 lines, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java View 1 chunk +1 line, -1 line 0 comments Download
A base/test/android/javatests/src/org/chromium/base/test/util/RestrictionSkipCheck.java View 1 chunk +72 lines, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/SkipCheck.java View 1 2 chunks +21 lines, -0 lines 0 comments Download
A base/test/android/junit/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheckTest.java View 1 chunk +93 lines, -0 lines 0 comments Download
A base/test/android/junit/src/org/chromium/base/test/util/RestrictionSkipCheckTest.java View 1 chunk +127 lines, -0 lines 0 comments Download
A base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java View 1 2 1 chunk +123 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
jbudorick
4 years, 9 months ago (2016-03-04 16:12:46 UTC) #2
jbudorick
+newt
4 years, 9 months ago (2016-03-04 16:49:58 UTC) #4
newt (away)
lgtm after question https://codereview.chromium.org/1761383002/diff/1/base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java File base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java (right): https://codereview.chromium.org/1761383002/diff/1/base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java#newcode7 base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java:7: import android.os.Build; One import from each ...
4 years, 9 months ago (2016-03-07 18:07:09 UTC) #5
Yaron
lgtm2 % newt's question
4 years, 9 months ago (2016-03-07 18:32:41 UTC) #6
jbudorick
+thakis for base/{base.gyp,BUILD.gn} https://codereview.chromium.org/1761383002/diff/1/base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java File base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java (right): https://codereview.chromium.org/1761383002/diff/1/base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java#newcode7 base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java:7: import android.os.Build; On 2016/03/07 18:07:09, newt ...
4 years, 9 months ago (2016-03-08 00:18:55 UTC) #8
newt (away)
Cool, thanks. lgtm. https://codereview.chromium.org/1761383002/diff/20001/base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java File base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java (right): https://codereview.chromium.org/1761383002/diff/20001/base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java#newcode61 base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java:61: Assert.assertTrue(annotations.isEmpty()); IMO, "assertEquals(0, annotations.size())" will produce ...
4 years, 9 months ago (2016-03-08 00:26:56 UTC) #9
jbudorick
https://codereview.chromium.org/1761383002/diff/20001/base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java File base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java (right): https://codereview.chromium.org/1761383002/diff/20001/base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java#newcode61 base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java:61: Assert.assertTrue(annotations.isEmpty()); On 2016/03/08 00:26:56, newt wrote: > IMO, "assertEquals(0, ...
4 years, 9 months ago (2016-03-08 01:49:26 UTC) #10
jbudorick
thakis: ping
4 years, 9 months ago (2016-03-09 14:27:21 UTC) #11
Nico
lgtm Sorry about the delay.
4 years, 9 months ago (2016-03-09 19:11:01 UTC) #12
jbudorick
On 2016/03/09 19:11:01, Nico wrote: > lgtm > > Sorry about the delay. np. thanks ...
4 years, 9 months ago (2016-03-10 00:32:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761383002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761383002/60001
4 years, 9 months ago (2016-03-10 00:33:00 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-10 02:14:24 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 02:15:58 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/acf0dd8e8dbf43d03330609890cbdf2334e14c02
Cr-Commit-Position: refs/heads/master@{#380307}

Powered by Google App Engine
This is Rietveld 408576698