Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1761373002: Switch SkPaintImageFilter over to new onFilterImage interface (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@if-follow-on
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch SkPaintImageFilter over to new onFilterImage interface This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761373002 Committed: https://skia.googlesource.com/skia/+/e6163bf35359900e048acc34551cefa67d88e1eb

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : clean up #

Patch Set 4 : update to ToT #

Patch Set 5 : Updated to match naming convention #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M include/effects/SkPaintImageFilter.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkPaintImageFilter.cpp View 1 2 3 4 2 chunks +23 lines, -19 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
robertphillips
4 years, 9 months ago (2016-03-04 16:17:13 UTC) #4
robertphillips
4 years, 9 months ago (2016-03-08 15:08:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761373002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761373002/80001
4 years, 9 months ago (2016-03-08 15:26:43 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/6870) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
4 years, 9 months ago (2016-03-08 15:28:19 UTC) #9
robertphillips
ping - I think this guy got lost in the shuffle.
4 years, 9 months ago (2016-03-09 12:32:37 UTC) #10
Stephen White
LGTM
4 years, 9 months ago (2016-03-09 15:34:49 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761373002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761373002/80001
4 years, 9 months ago (2016-03-09 15:37:05 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 18:05:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761373002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761373002/80001
4 years, 9 months ago (2016-03-09 18:16:47 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:17:44 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/e6163bf35359900e048acc34551cefa67d88e1eb

Powered by Google App Engine
This is Rietveld 408576698