Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1761233003: Add zlib dependency for dart_bootstrap build (Closed)

Created:
4 years, 9 months ago by Bill Hesse
Modified:
4 years, 9 months ago
Reviewers:
kasperl, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add zlib dependency for dart_bootstrap build The Dartium build does not include io components in the libraries, which are what pull in zlib for the non-dartium builds of the SDK. But it does build dart_bootstrap, which needs zlib. It actually should not need to build dart_bootstrap, since it is useless without io capabilities. BUG= R=kasperl@google.com Committed: https://github.com/dart-lang/sdk/commit/f425c829858565e6a4e21b32d6baf796303a937a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/bin/bin.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bill Hesse
4 years, 9 months ago (2016-03-04 10:37:22 UTC) #2
kasperl
LGTM. Thanks for trying to make the bots greener, Bill!
4 years, 9 months ago (2016-03-04 11:28:30 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as f425c829858565e6a4e21b32d6baf796303a937a.
4 years, 9 months ago (2016-03-04 12:15:48 UTC) #5
Ivan Posva
4 years, 9 months ago (2016-03-04 18:01:31 UTC) #6
Message was sent while issue was closed.
Bill,

Thanks for the quick fix. I will fix the use of zlib in dart_bootstrap, which is
not needed and will be removed.

-Ivan

Powered by Google App Engine
This is Rietveld 408576698