chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc - Issue 1761183002: color_utils cleanup:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

Issue 1761183002: color_utils cleanup: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/themes/theme_properties.h ('K') | « chrome/browser/ui/sync/profile_signin_confirmation_helper.cc ('k') | chrome/browser/ui/views/download/download_item_view.cc » ('j') | chrome/browser/ui/views/download/download_item_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

index 5d3ac9b6d84f9eabc5e4f4c44de3dd6aff36e079..03d15639249e0d4042c3449bcb69a4cc6e29d743 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

@@ -154,7 +154,7 @@ void BookmarkBarInstructionsView::UpdateColors() {

SkColor bg = theme_provider->GetColor(ThemeProperties::COLOR_TOOLBAR);

SkColor link_color =

GetNativeTheme()->GetSystemColor(ui::NativeTheme::kColorId_LinkEnabled);

- bool link_has_contrast = color_utils::GetContrastRatio(link_color, bg) >=

+ bool link_has_contrast = color_utils::ContrastRatio(link_color, bg) >=

color_utils::kMinimumReadableContrastRatio;

import_link_->SetUnderline(!link_has_contrast);

import_link_->SetEnabledColor(link_has_contrast ? link_color : text_color);