Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1761163003: Support building Vulkan on Linux. (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -34 lines) Patch
M gyp/gpu.gyp View 1 1 chunk +23 lines, -14 lines 0 comments Download
M gyp/shaderc.gyp View 2 chunks +44 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
bsalomon
4 years, 9 months ago (2016-03-04 19:26:42 UTC) #4
egdaniel
https://codereview.chromium.org/1761163003/diff/1/gyp/gpu.gyp File gyp/gpu.gyp (right): https://codereview.chromium.org/1761163003/diff/1/gyp/gpu.gyp#newcode257 gyp/gpu.gyp:257: 'vulkan_lib_name': '-lvulkan', does the sdk install the lib in ...
4 years, 9 months ago (2016-03-04 19:38:41 UTC) #5
bsalomon
https://codereview.chromium.org/1761163003/diff/1/gyp/gpu.gyp File gyp/gpu.gyp (right): https://codereview.chromium.org/1761163003/diff/1/gyp/gpu.gyp#newcode257 gyp/gpu.gyp:257: 'vulkan_lib_name': '-lvulkan', On 2016/03/04 19:38:40, egdaniel wrote: > does ...
4 years, 9 months ago (2016-03-04 20:50:08 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761163003/20001
4 years, 9 months ago (2016-03-04 21:11:55 UTC) #8
egdaniel
lgtm
4 years, 9 months ago (2016-03-04 21:22:54 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 21:28:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761163003/20001
4 years, 9 months ago (2016-03-04 21:37:04 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 21:38:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/41dc3d63a587b6bf4e437ac114485e62c42abe41

Powered by Google App Engine
This is Rietveld 408576698