Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1761123002: Add documentation for linux sysroot images (Closed)

Created:
4 years, 9 months ago by Sam Clegg
Modified:
4 years, 9 months ago
Reviewers:
Lei Zhang, binji
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add documentation for linux sysroot images Committed: https://crrev.com/30e4728b9ca8623ad6d7ce4bc29b781831969e40 Cr-Commit-Position: refs/heads/master@{#379164}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
A docs/linux_sysroot.md View 1 2 3 4 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sam Clegg
4 years, 9 months ago (2016-03-03 23:46:04 UTC) #3
Sam Clegg
+binji since thestig is OOO
4 years, 9 months ago (2016-03-03 23:46:38 UTC) #5
binji
lgtm https://codereview.chromium.org/1761123002/diff/60001/docs/linux_sysroot.md File docs/linux_sysroot.md (right): https://codereview.chromium.org/1761123002/diff/60001/docs/linux_sysroot.md#newcode4 docs/linux_sysroot.md:4: rather than building against the libraries installed in ...
4 years, 9 months ago (2016-03-03 23:54:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761123002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761123002/80001
4 years, 9 months ago (2016-03-03 23:59:30 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-04 01:30:08 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 01:31:22 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/30e4728b9ca8623ad6d7ce4bc29b781831969e40
Cr-Commit-Position: refs/heads/master@{#379164}

Powered by Google App Engine
This is Rietveld 408576698